#4396 closed Defect (fixed)
Revert avatar doesn't remove the avatar
| Reported by: | coldtrick | Owned by: | sembrestels |
|---|---|---|---|
| Priority: | normal | Milestone: | Elgg 1.8.6 |
| Component: | Core | Version: | Github Master |
| Severity: | minor | Keywords: | |
| Cc: | brett@… | Difficulty: | easy |
Description (last modified by brettp)
Related to #3272.
Revert avatar currently only unsets icontime, but is doesn't remove the icon from the filesystem. Why not?
If many users revert their icon the diskspace is still used, this may not be a problem on your own server as you control the diskspace, but is may be on shared hosts where you have to pay for diskspace.
It should be easy enough to fix this, also the crop coordinates aren't unset when reverting.
Change History (9)
comment:1 Changed 14 months ago by brettp
- Description modified (diff)
- Difficulty set to easy
- Milestone changed from Needs Review to Elgg 1.8.5
comment:2 Changed 13 months ago by sembrestels
- Owner set to sembrestels
- Status changed from new to assigned
comment:3 Changed 13 months ago by sembrestels
comment:4 Changed 12 months ago by sembrestels
Repushed to 1.8: https://github.com/Elgg/Elgg/pull/230
comment:5 Changed 12 months ago by Sem
- Resolution set to fixed
- Status changed from assigned to closed
Fixes #4396. Revert avatar also deletes avatar's files and crop coords now.
Changeset: 3643efd144c3a9190018100665d02ec798989bfd
comment:6 follow-up: ↓ 7 Changed 12 months ago by sembrestels
So, the name for the action is still revert?
comment:7 in reply to: ↑ 6 Changed 11 months ago by cash
Replying to sembrestels:
So, the name for the action is still revert?
I don't think so. Check the 1.8 branch.
comment:8 Changed 11 months ago by Sem
Fixes #4396. Revert avatar also deletes avatar's files and crop coords now.
Changeset: 3643efd144c3a9190018100665d02ec798989bfd
comment:9 Changed 11 months ago by Cash Costello
Merge pull request #230 from sembrestels/avatar-revert1.8
Fixes #4396. Revert avatar also deletes avatar's files and crop coords now.
Changeset: edb6a30963e704a102ba0032af98b5ccbb6bdbe4
Also, "revert" is a weird term for this. Unless it goes back to the previous avatar, it should just be "remove."