We have moved to Github. Please open tickets there.

Opened 13 months ago

Closed 12 months ago

Last modified 11 months ago

#4480 closed Enhancement (fixed)

forward to referrer after comment delete

Reported by: mrclay Owned by: mrclay
Priority: normal Milestone: Elgg 1.8.6
Component: Core Version: 1.8.3
Severity: minor Keywords:
Cc: brett@… Difficulty:

Description

What would be the harm in forwarding to REFERER instead of $entity->getURL()?

E.g. A person commenting while viewing page 3 of paginated comments should not be pushed back to the 1st.

Also I have a situation where a comment form needs to be on a different page than the underlying entity. I have Document objects which are represented by multiple Revision objects, which hold all comments. On the Document page I show comments for the latest revision, but leaving a comment always forwards to the Revision URL, which is confusing.

Change History (9)

comment:1 Changed 13 months ago by mrclay

  • Summary changed from forward to referrer after comment add/delete to forward to referrer after comment delete

Adding a comment already forwards to REFERER.

comment:2 Changed 13 months ago by ewinslow

Yes please.

comment:3 Changed 12 months ago by ewinslow

  • Milestone changed from Needs Review to Elgg 1.8.x

comment:4 Changed 12 months ago by mrclay

  • Owner set to mrclay
  • Status changed from new to assigned
  • Type changed from Feature Request to Enhancement

1.8 PR ​https://github.com/Elgg/Elgg/pull/238

comment:5 Changed 12 months ago by ewinslow

  • Milestone changed from Elgg 1.8.x to Elgg 1.8.6

comment:6 Changed 12 months ago by Steve Clay

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixes #4480: Forward to REFERER after comment delete

Changeset: 5a432ff2474e70caf88c19a8b413405d14e61d4d

comment:7 Changed 12 months ago by Cash Costello

Merge pull request #238 from mrclay/patch-6

Fixes #4480: Forward to REFERER after comment delete

Changeset: e1ad0033a34576b663caca96091eeed012d3447b

comment:8 Changed 11 months ago by Steve Clay

Fixes #4480: Forward to REFERER after comment delete

Changeset: 5a432ff2474e70caf88c19a8b413405d14e61d4d

comment:9 Changed 11 months ago by Cash Costello

Merge pull request #238 from mrclay/patch-6

Fixes #4480: Forward to REFERER after comment delete

Changeset: e1ad0033a34576b663caca96091eeed012d3447b

Note: See TracTickets for help on using tickets.