system_log(): Sniff the version and only use ip_address for latest version.

[brettp]

Problematic upgrades if going from < 1.8.3 to 1.8.4.

[brettp]

Got to thinking, instead of a version sniff how does everyone feel if I add an internal var that will disable the sys log, and then we use that during upgrades? I don't think the syslog is particularly useful for upgrades.

[brettp]

Dupe of #4326. Now to figure out why it's not working correctly.

[Brett Profitt]

Refs #4487. Turning off system log (even more) during upgrades. Removed debug call to system_log() in create_annotation().

Changeset: 25b1a1ea11182b6fc195f4cca76ec4788d79c65e

[captnbob]

Brett, you asked for a Stack Trace on this problem. Here is mine with the exception being that this is a new install. I added a plugin and ran "upgrade.php" and got the same error:
Stack trace:
#0 /home/mysite/engine/lib/database.php(493): execute_query()
#1 /home/mysite/engine/lib/upgrades/2012012000-1.8.3-ip_in_syslog-87fe0f068cf62428.php(12): update_data()
#2 /home/mysite/engine/lib/upgrade.php(62): include('/home/mysite/...')
#3 /home/mysite/engine/lib/upgrade.php(255): upgrade_code()
#4 /home/mysite/upgrade.php(27): version_upgrade()
#5 {main}
[code:protected] => 0
[file:protected] => /home/mysite/engine/lib/database.php
[line:protected] => 261
[trace:private] => Array
(
[0] => Array
(
[file] => /home/mysite/engine/lib/database.php
[line] => 493
[function] => execute_query
)

[1] => Array
(
[file] => /home/mysite/engine/lib/upgrades/2012012000-1.8.3-ip_in_syslog-87fe0f068cf62428.php
[line] => 12
[function] => update_data
)

[2] => Array
(
[file] => /home/mysite/engine/lib/upgrade.php
[line] => 62
[args] => Array
(
[0] => /home/mysite/engine/lib/upgrades/2012012000-1.8.3-ip_in_syslog-87fe0f068cf62428.php
)

[function] => include
)

[3] => Array
(
[file] => /home/mysite/engine/lib/upgrade.php
[line] => 255
[function] => upgrade_code
)

[4] => Array
(
[file] => /home/mysite/upgrade.php
[line] => 27
[function] => version_upgrade
)

)

)

[Brett Profitt]

Refs #4487. Turning off system log (even more) during upgrades. Removed debug call to system_log() in create_annotation().

Changeset: 25b1a1ea11182b6fc195f4cca76ec4788d79c65e

[Cash Costello]

Fixes #4487 turned off logging for sites that haven't been upgraded with ip address column

Changeset: 242ea5fa2b1ac775b74cf118a8b81d79e531104a

[Cash Costello]

Fixes #4487 turned off logging for sites that haven't been upgraded with ip address column

Changeset: 242ea5fa2b1ac775b74cf118a8b81d79e531104a