Enabling entity doesn't enable it's children entities.

[zhoppy]

Problem: Trying to unban a user doesn't work properly as their widgets aren't available.

The admin/user/ban action will set the enabled column in the entity table to 'no' for that user's entity and all of the entities that belong to it.

The admin/user/unban action, which calls ElggUser::enable(), doesn't change the enabled value for the user's children entities (widgets.) So the user's profile shows up again but without any widgets.

My proposed solution is add a function called enable_entites($parent_guid) to the entities lib and to override the enable function in ElggUser to call both the parent ElggEntity enable function as well as enable_entites.

Add to: engine/lib/entities.php

/**
 * Enable an entities' children. Make sure you enable the entity first as well
 *
 * @param int $guid The parent entity's guid.
 */	
function enable_entities($parent_guid) {
	global $CONFIG;
	
	$parent_guid = (int)$parent_guid;
	
	// Override access only visible entities
	$access_status = access_get_show_hidden_status();
	access_show_hidden_entities(true);
	$entities = get_entities("", "", $parent_guid, "", 0);
	access_show_hidden_entities($access_status);
	
	$result = true;
	foreach($entities as $entity) {
		$result &= enable_entity($entity->guid);
	}
	return $result;
}

Add to engine/lib/users.php:

public function enable() {
	if(parent::enable()) {
		return enable_entities($this->get('guid'));
	}
	
	return false;
}

[marcus]

Banning method has now been changed so as to not physically disable a user.

[srokap]

Bug with enabling of children entities still occurs in head 1.8 branch. Entities enabled recursively are limited to 10 items by default.

[srokap]

Pull request for this ticket: ​https://github.com/Elgg/Elgg/pull/271

[cash]

Thanks for catching this!

[Srokap]

Fixes #450 Enabling entity doesn't enable it's children entities.

Changeset: 34de6036015f072cd809c3240228f56b23c7de91

[Cash Costello]

Merge pull request #271 from Srokap/ticket_450

Fixes #450 Enabling entity doesn't enable it's children entities.

Changeset: 19e2a8d99b0aab82e8213d171547486500b0784f

[Srokap]

Fixes #450 Enabling entity doesn't enable it's children entities.

Changeset: 34de6036015f072cd809c3240228f56b23c7de91