Opened 12 months ago
Last modified 11 months ago
#4559 new Task
Throw exceptions on system failures rather than returning false
| Reported by: | mrclay | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Elgg 1.9.0 |
| Component: | Core | Version: | Github Master |
| Severity: | minor | Keywords: | |
| Cc: | brett@…, evan@… | Difficulty: |
Description
Particularly low-level, non-API functions/methods (e.g. row_to_elggmetadata) which should not fail under normal conditions should throw instead of returning false/null. This would allow these functions to have fewer return types and remove the need for the caller to have code handling the error (which they usually don't anyway, most just pass the buck).
Change History (1)
comment:1 Changed 11 months ago by cash
- Milestone changed from Needs Review to Elgg 1.9.0
Note: See
TracTickets for help on using
tickets.

Agreed.