Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

walled garden: Transparent corners for walled garden backgrounds (Trac #4636) #4636

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 7 comments
Labels
Milestone

Comments

@elgg-gitbot
Copy link

Original ticket http://trac.elgg.org/ticket/4636 on 42490068-02-25 by trac user juho.jaakkola, assigned to trac user juho.jaakkola.

Elgg version:

The round corners of background images in _graphics/walled_garden/ should be transparent.

@elgg-gitbot
Copy link
Author

trac user juho.jaakkola wrote on 42490074-09-29

Is there a reason why the views for non-logged in users use background images instead of divs and css?

@elgg-gitbot
Copy link
Author

cash wrote on 42490190-01-22

We would definitely accept a pull request that either switches the images so that the corners are transparent or that switches to using a pure css solution that looks like same. Thanks!

@elgg-gitbot
Copy link
Author

trac user juho.jaakkola wrote on 42495414-11-25

I prefer the css solution so it would be easier to customize. The only problem with it is that the columns in the two-column version wouldn't be as high. Min-height would work with the default login page but not if someone has changed the content of the columns.

@elgg-gitbot
Copy link
Author

cash wrote on 42495637-02-17

That may have been the reason that we chose to use the images. We have to assume that people will change the content (or have site names of different lengths or login boxes with extra information).

@elgg-gitbot
Copy link
Author

trac user juho.jaakkola wrote on 42659992-03-14

#375

@elgg-gitbot
Copy link
Author

Milestone changed to Elgg 1.8.13 by brettp on 43029965-08-05

@elgg-gitbot
Copy link
Author

cash wrote on 43074229-05-09

Fixed in 2b2dc7f/elgg

sembrestels pushed a commit to sembrestels/Elgg that referenced this issue Feb 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant