#4687 closed Defect (fixed)
handle URLs on plugins that include only handler name
| Reported by: | cash | Owned by: | sembrestels |
|---|---|---|---|
| Priority: | normal | Milestone: | Elgg 1.8.9 |
| Component: | Core | Version: | 1.8 |
| Severity: | minor | Keywords: | |
| Cc: | brett@… | Difficulty: |
Description
Some are serving 404 pages if you hit http://example.org/<handler>/. I expect that would serve the same content as http://example.org/<handler>/all
Change History (7)
comment:1 Changed 11 months ago by sembrestels
- Owner set to sembrestels
- Status changed from new to assigned
comment:2 Changed 11 months ago by sembrestels
There is a related issue: 403 Forbidden in http://your.elgg/pages
This is because we have a pages folder in the elgg root.
comment:3 Changed 11 months ago by cash
We don't want to change the core page handler. Each plugin should handle it.
Maybe this instead:
if (empty($page[0])) {
$page[0] = 'all';
}
comment:4 Changed 11 months ago by sembrestels
comment:5 Changed 11 months ago by cash
Thanks, Sem
comment:6 Changed 11 months ago by Sem
- Resolution set to fixed
- Status changed from assigned to closed
Fixes #4687. Handle URLs on plugins that include only handler name.
Changeset: d6953c9955b2b9e3c245936e448e7be41058bb9b
comment:7 Changed 11 months ago by Cash Costello
Merge pull request #318 from sembrestels/handle-all
Fixes #4687. Handle URLs on plugins that include only handler name.
Changeset: 901cb69ba0b40d247bea5b0e1b4e4588a86800c1

Do you refer to add this code
if (empty($page[0])) { forward("$handler/all"); }in all page handlers that is missing, or to change the core page_handler function?