We have moved to Github. Please open tickets there.

Opened 10 months ago

Closed 8 months ago

Last modified 8 months ago

#4725 closed Defect (fixed)

Embed plugin removes file upload form when used on file description

Reported by: beck24 Owned by: beck24
Priority: normal Milestone: Elgg 1.8.9
Component: File Version: 1.8
Severity: minor Keywords:
Cc: brett@… Difficulty:

Description

To reproduce:
Enable files, embed plugins.
Add a new file, on the file description click "embed content", choose "upload a file".
Select a new file and submit. The new file will be uploaded but the original file upload form has been removed from the DOM.

Additionally, if you submit the form without selecting a file you get a correct error message but form does not reappear - stays on ajax/loader view.

Change History (4)

comment:1 Changed 10 months ago by beck24

  • Owner set to beck24
  • Status changed from new to assigned

comment:2 Changed 10 months ago by sembrestels

  • Component changed from Core to File
  • Milestone changed from Needs Review to Elgg 1.8.9

Confirmed.

comment:3 Changed 8 months ago by Matt Beckett

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixes #4725 - no longer removes file upload form outside of embed lightbox, no longer hangs on throbber when the form returns an error.

Changeset: d8da958e206b8f9b8b2e578a6572bcae1c08df0d

comment:4 Changed 8 months ago by Steve Clay

Merge pull request #328 from beck24/#4725-embed-file-form

Fixes #4725 - embed form on file upload textarea removes file upload form

Changeset: 766fe8ebbcc600982dddce4d93b15b65a7b8c1fb

Note: See TracTickets for help on using tickets.