Bookmark form should allow introduce a container

[sembrestels]

The bookmarklet and the bookmark it button in the sidebar allow to bookmark any page, but only for your profile.

It would be really interesting to allow set another container in this cases.

[sembrestels]

PR: ​https://github.com/Elgg/Elgg/pull/331

[ewinslow]

Not super feeling this one. Has this come up in your networks before? Wonder if we could get input from some other devs here.

[sembrestels]

We are using it in our networks because is really uncomfortable add a bookmark to a group with the current code. In our case is more usually add a bookmark in a group than in a profile.

You can find a better explication in our usability group: ​https://n-1.cc/pg/pages/view/650728

[mrclay]

Definitely agree on this being a usability improvement. Especially when using the bookmarklet, since you're not arriving from Elgg, the page owner block still doesn't quite make it clear to users where the new object would go. And having to use a separate bookmarklet for every container is disastrous for usability.

The only downsides I see is breaking the convention we have in place, and how to allow sane access defaults without knowing container.

I'd like to test this soon.

[mrclay]

​Here's a refactoring that moves the container selector into its own view (which could be moved into 1.9).

We should dynamically re-populate the access input for switching between containers.