trac user mrclay wrote on 42551427-12-12

Hmm, comments on both finfo_file and mime_content_type seem to indicate problems with both. Can we decide on a small number of problematic extensions? Should we only try the manual lookup if certain values are returned?

Milestone changed to Elgg 1.8.9 by trac user mrclay on 42551427-12-12

cash wrote on 42551454-04-12

This is a very hard problem. It is affected by browser and server configuration. If you fallback on file extensions, you risk someone uploading something nasty and having it be misrepresented by your site.

MP3 files are especially difficult because MP3 is a stream rather than file format. There is no header so no magic code to go off of.

I'd like to see the appropriate hooks in Elgg 1.9 so that sites can customize their mime type detection plus do virus checking.

ewinslow wrote on 42551751-05-24

I'd like to avoid doing anything just to accommodate PHP 5.2 since we're going to drop support soon. Cash's reason are much more compelling to me.

Milestone changed to Elgg 1.8.12 by brettp on 42934480-07-19

cash wrote on 42939730-05-24

Assigning to 1.9 where we can add the appropriate hooks.

Milestone changed to Elgg 1.9.0 by cash on 42939730-05-24