We have moved to Github. Please open tickets there.

Opened 10 months ago

Last modified 4 months ago

#4777 new Defect

Blog drafts can be exposed

Reported by: bruno Owned by:
Priority: normal Milestone: Elgg 1.8.x
Component: Core Version: 1.8
Severity: minor Keywords:
Cc: brett@… Difficulty:

Description

Even when a blog post is in draft mode, a user can annotate it. It has the unfortunate side effect of creating a river item which then leads to the draft blog post (which should really not be visible)

Attachments (1)

save_draft.php (2.2 KB) - added by bruno 9 months ago.
Added jquery code to remove comments when status is draft

Download all attachments as: .zip

Change History (4)

Changed 9 months ago by bruno

Added jquery code to remove comments when status is draft

comment:1 Changed 4 months ago by ewinslow

  • Keywords annotation draft blog removed
  • Milestone changed from Needs Review to Elgg 1.8.x
  • Summary changed from Annotation on a draft blog post to Blog drafts can be exposed

Blog drafts should always be saved as private, only once published should they get the access_id specified by the user.

comment:2 follow-up: Changed 4 months ago by ewinslow

I ran into this problem on a site I'm developing. elgg_get_enitities does not do what you expect when there are blog drafts involved. Some drafts were being exposed on the homepage.

comment:3 in reply to: ↑ 2 Changed 4 months ago by bruno

Replying to ewinslow:

I ran into this problem on a site I'm developing. elgg_get_enitities does not do what you expect when there are blog drafts involved. Some drafts were being exposed on the homepage.

Yes, and there are other issues. Apart from the whole discussion on https://groups.google.com/forum/#!searchin/elgg-development/draft/elgg-development/inhSpjNCMwg/BdZgZf_qjIQJ, there is also the fact that, because the river uses the creation date, when a blog post is finally published, it will not necessarily show up at the top of the river because the creation date may be quite old.

Note: See TracTickets for help on using tickets.