New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HTML5 validation errors (Trac #4801) #4801
Comments
What is size on ? |
And what about |
Does it validate if you change "meta" to "alternate"? |
@sembrestels Regarding size, I think input/file specifies a default size. You can test by validating the file upload page. |
@ewinslow I couldn't find any duplicate form IDs. I only found 2 instances of form IDs in Elgg - the group invitation form and the messages reply form. |
@cash, Why don't we use You have an approach here. |
http://caniuse.com/#search=time |
Ok, I undersand. We can use html5shiv yet, but I understand this is messy and can cause problems. |
Html5shim is a fine solution, I think, to the time issue. |
Not worth it to add all that for just switching from abbr to time. Shims often have side effects and add bloat. If this was a really essential feature, I could see trying out html5shiv. |
I find these reasons less than compelling. It's a tiny well tested library that is only needed for ie8. |
I don't find including a library just to switch from |
@cash, I see your insistence and I won't be more boring. Just say that if we want maintain compatibility with IE8, we should include html5shiv anyway. As |
Moving html5shim discussion to #5492. |
I could not find any form id duplicates so closing this. Please open a new ticket for additional validation fixes. |
Original ticket http://trac.elgg.org/ticket/4801 on 42619549-05-21 by ewinslow, assigned to unknown.
<acronym>
<input type=file>
Not fixing in 1.9:
The text was updated successfully, but these errors were encountered: