Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow modifying BODY class and data-* attributes (Trac #4830) #4830

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 2 comments
Closed

Allow modifying BODY class and data-* attributes (Trac #4830) #4830

elgg-gitbot opened this issue Feb 16, 2013 · 2 comments
Assignees
@mrclay
Labels
engine feature

Comments

@elgg-gitbot
Copy link

Original ticket http://trac.elgg.org/ticket/4830 on 42653765-07-21 by trac user mrclay, assigned to unknown.

Elgg version: 1.8

Strategy for BODY.class:

  1. create class ElggTokenList based on [http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#interface-domtokenlist DOMTokenList]
  2. make a singleton available
  3. place a unique string placeholder for BODY.class in page/default
  4. filter the page/default view, replacing the placeholder with the stringified token list.

This allows descendant views to have a chance to modify the classname before output.
@elgg-gitbot
Copy link
Author

Milestone changed to Elgg 1.10.0 by cash on 43101261-11-17

@Srokap Srokap mentioned this issue Dec 18, 2013
Merged
@ewinslow ewinslow removed this from the Elgg 1.10.0 milestone Jun 13, 2014
@ewinslow
Copy link
Contributor

ewinslow commented Jan 3, 2015

Closing for lack of interest

@ewinslow ewinslow closed this as completed Jan 3, 2015
@mrclay mrclay self-assigned this Jan 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrclay mrclay

Labels
engine feature
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mrclay @ewinslow @elgg-gitbot