Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arbitrary simplecache requests can cause cache regenerate (Trac #4897) #4897

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 2 comments
Closed

Arbitrary simplecache requests can cause cache regenerate (Trac #4897) #4897

elgg-gitbot opened this issue Feb 16, 2013 · 2 comments
Labels
engine
Milestone
Elgg 1.9.0 Releas...

Comments

@elgg-gitbot
Copy link

Original ticket http://trac.elgg.org/ticket/4897 on 42841593-12-10 by trac user mrclay, assigned to unknown.

Elgg version: 1.8

Any simplecache request that doesn't map to an existing view causes the [https://github.com/Elgg/Elgg/blob/1.8/engine/handlers/cache_handler.php#L96 simplecache to be regenerated]. E.g. http://example.org/cache/css/default/x.1.css

Under 1.8, this causes all visitors to re-download simplecached files.
Under 1.9, the system may have to minify all the CSS/JS! Sloooow.

Suggestion: Only regenerate if the given view exists and is registered with simplecache.
@elgg-gitbot elgg-gitbot mentioned this issue Feb 17, 2013
Closed
@elgg-gitbot
Copy link
Author

trac user mrclay wrote on 43106517-12-25

Is there a reason we don't generate individual views on their first request, and invalidate by purging the cache dir?

@elgg-gitbot elgg-gitbot reopened this Feb 17, 2013
@Srokap
Copy link
Contributor

Srokap commented Mar 21, 2013

Fixed in 1.8.14

@cash cash closed this as completed Mar 21, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
engine
Milestone
Elgg 1.9.0 Release Candidate
Development

No branches or pull requests
3 participants
@cash @Srokap @elgg-gitbot