trac user rivervanrain wrote on 42895118-05-12

Commit: [https://github.com/RiverVanRain/Elgg/commit/f8359f983877aa5971497bbcf5f1fe87c35ed939]

trac user mrclay wrote on 42895638-09-04

rivervanrain but once the object creation item drops off the first page, you'll no longer see new comments at the top of the stream. You need both river items.

If someone posts a new comment, I expect that at the top of the stream, not 3 pages down just because the item commented on is old.

trac user webgalli wrote on 42916446-07-20

What about an extra column for last_action and list by last_action?

This continues to be a frustrating problem....

My main project bumps the parent object river item timestamp on receiving a comment and only shows individual comment river items when viewing a single user's stream. This makes the river bounce a lot but still seems more usable than showing comments out of context.

I think I could reduce the bouncing by only bumping when the latest comment is more than N seconds after the last bump time.

...then highlight comment(s) since the previous bump.

http://www.slideshare.net/danmckinley/etsy-activity-feeds-architecture (start at slide 36)
https://www.quora.com/What-are-best-practices-for-building-something-like-a-News-Feed
https://github.com/tschellenbach/Stream-Framework/blob/master/README.md

"My main project bumps the parent object river item timestamp on receiving a comment and only shows individual comment river items when viewing a single user's stream. This makes the river bounce a lot but still seems more usable than showing comments out of context."

This is really good - how we can do this in Elgg 1.9.x/ Elgg 1.10 ?

@dranii, new features go into 1.11 at this point.

And I really age this could improve things.

agree*

We changed the all activity listing to not show comments/responses.
So the create blog river activity no longer shows the responses / comments. This way there is no duplication in the listing.
On the activity listing of the user the responses are shown

We changed the all activity listing to not show comments/responses.
So the create blog river activity no longer shows the responses / comments. This way there is no duplication in the listing.
On the activity listing of the user the responses are shown

This option does not help us... need to go for an option where we maybe do not create comment river items but instead bubble related river items (like blog create) to the top (so the responses are visible with their recent responses).. This might require an extra 'time_updated' timestamp with the river item

How about that: strictly speaking, there are no duplicate river entries!

The impression of duplicate river entries only comes from the extra "service" of showing the latest comments posted to an entity in the river to allow for responding directly from the activity page. Only in the case that there haven't been any other river entries added between the entity added and the comments made it might seem that there are duplicate river entries. But there are not the same!

No longer added a separate river entry for the comment but only update the time_updated for the entity added river entry seems not a good idea because you will only see the latest 3 comments made on the activity page but no longer any other older comments. And it breaks the chronological order of the river entries!

How about an alternative way to deal with it: leave the separate comment entries in the river unchanged. But adding a site option to set a default regarding the presentation of the comments in the original entity river entry. The option would allow for showing the responses either like they are now (for people not caring about the "duplicate" comments) or alternatively show the responses collapsed and only make them visible on demand.

I think the way things were in Elgg 3x was quite good and perhaps also in 4x - need to test.
I fully like this:
"The impression of duplicate river entries only comes from the extra "service" of showing the latest comments posted to an entity in the river to allow for responding directly from the activity page. Only in the case that there haven't been any other river entries added between the entity added and the comments made it might seem that there are duplicate river entries. But there are not the same!"
I am not sure I have understood the 3rd part (an alternative way) - some screenshots of the suggestion would be good, if there is time. I would like to test this more for myself and post what I found/what I feel - do we have others also interested in this, as this is a vital way how we look at the site on first entry after logging in. Thanks @iionly

This needs more thinking and probably is going to be breaking. Putting this on Elgg 5 for now.