Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink how we do exports (Trac #5017) #5017

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 6 comments
Closed

Rethink how we do exports (Trac #5017) #5017

elgg-gitbot opened this issue Feb 16, 2013 · 6 comments

Comments

@elgg-gitbot
Copy link

Original ticket http://trac.elgg.org/ticket/5017 on 43084402-06-08 by cash, assigned to unknown.

Elgg version: 1.8

Right now a lot of information is available if someone wants to make arbitrary requests on the export endpoint. We need to develop some use cases for export.

If exporting is primarily about giving users control over there data, only that user should be able to export the data. If it is about supporting migrating data to a new site/platform, doing it through http calls is tremendously inefficient.

@elgg-gitbot
Copy link
Author

cash wrote on 43084404-06-03

As an example of the confusion generated by this, see #440

@elgg-gitbot
Copy link
Author

trac user srokap wrote on 43084724-08-06

Let's add plugin hook ('export', $entity->getType()) to export handler to allow blocking it.

Additionally we colud consider some profiles of enabling exportability (export disabled by default?), ie. no-export, admin-only, open (current logic).

Second question are exportable fields, but this is wider issue as it's used also in various viewtypes for fields selection. I've mentioned before problem with the view serving exportable output that serves metadata and relations - that shouldn't happen IMHO (dont mistake it with default /view/GUID page handler)

@ewinslow ewinslow removed this from the Elgg 1.10.0 milestone Jun 13, 2014
@ewinslow
Copy link
Contributor

ewinslow commented Jun 6, 2015

Personally I think I'd like to drop the export APIs. They give out too much information by default...

@mrclay
Copy link
Member

mrclay commented Jun 6, 2015

Very very much agreed

@ewinslow ewinslow added this to the Elgg 2.0.x milestone Jun 6, 2015
@ewinslow
Copy link
Contributor

ewinslow commented Jun 6, 2015

2.0 is our opportunity for this

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jun 7, 2015
This removes the “export” URL endpoints and removes all other /engine/handlers.
Requests for these resources now all use the front controller `index.php`.

Fixes Elgg#8425
Fixes Elgg#5017
@mrclay
Copy link
Member

mrclay commented Jun 7, 2015

PR #8427

mrclay added a commit to mrclay/Elgg-leaf that referenced this issue Jun 8, 2015
This removes the “export” URL endpoints and removes all other /engine/handlers.
Requests for these resources now all use the front controller `index.php`.

Fixes Elgg#8425
Fixes Elgg#5017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants