We have moved to Github. Please open tickets there.

Opened 4 years ago

Closed 4 years ago

#648 closed Defect (fixed)

possible cut and paste error in get_annotations()

Reported by: costelloc Owned by:
Priority: normal Milestone:
Component: Core Version: 1.1
Severity: minor Keywords:
Cc: brettp Difficulty:

Description

This is for version 1.2 of Elgg (I can select a milestone of 1.2 but cannot set version to be 1.2)

Current code:

    if ($entity_guid != 0 && !is_array($owner_guid)) {
      $where[] = "a.entity_guid=$entity_guid";
    } else if (is_array($owner_guid)) {
      $where[] = "a.entity_guid in (". implode(",",$entity_guid) . ")";
    }

There is a mixing of entity_guid and owner_guid. Should be

    if ($entity_guid != 0 && !is_array($entity_guid)) {
      $where[] = "a.entity_guid=$entity_guid";
    } else if (is_array($entity_guid)) {
      $where[] = "a.entity_guid in (". implode(",",$entity_guid) . ")";
    }

tortoise svn patches are giving me line ending problems and I don't have access to my linux box or I'd upload a patch.

Change History (1)

comment:1 Changed 4 years ago by marcus

  • Resolution set to fixed
  • Status changed from new to closed

(In [svn:2533]) Fixes #648: Copy and paste error corrected.

Note: See TracTickets for help on using tickets.