Opened 4 years ago
Closed 4 years ago
#649 closed Defect (fixed)
Add friend can fail and still return success message
| Reported by: | costelloc | Owned by: | |
|---|---|---|---|
| Priority: | low | Milestone: | |
| Component: | Core | Version: | 1.1 |
| Severity: | trivial | Keywords: | |
| Cc: | brettp | Difficulty: |
Description
In actions/friends/add.php, the return value of addFriend() is not checked. user_add_friend() can return false and the success message is still displayed. A simple fix is to check the return value and then set $errors = true;.
To test: log in to the community site and then click this link: http://community.elgg.org/action/friends/add?friend=15
It will display that you've successfully become friends with the Server Optimisation group.
Change History (1)
comment:1 Changed 4 years ago by marcus
- Resolution set to fixed
- Status changed from new to closed
Note: See
TracTickets for help on using
tickets.
(In [svn:2529]) Closes #649: Added checking to report when friend add fails.