Annotation update action fail should not delete annotation

[hidef]

update_annontations returns false in case it fails

[Facyla]

The submitted patch returns false when update_annotation fails.. BUT still deletes the annotation itself !
I think update_annotation(à should return true or false, based on success, but not delete the updated annotation in the process, whatever happens. If the annotation should be deleted, let do it depending on update result, or via the event hook.

I don't know yet how to submit diff patches, but here's the change based on 1.8 : ​http://reference.elgg.org/1.8/annotations_8php_source.html#l00132
FROM :
00167 if (elgg_trigger_event('update', 'annotation', $obj)) {
00168 return true;
00169 } else {
00170 @todo add plugin hook that sends old and new annotation information before db access
00171 elgg_delete_annotation_by_id($annotation_id);
00172 }

TO :
00167 if (elgg_trigger_event('update', 'annotation', $obj)) {
00168 return true;
00169 } else {
00170 @todo add plugin hook that sends old and new annotation information before db access
00171 return false;
00172 }

[Facyla]

formatted code excerpt...

Changes based on 1.8 : ​http://reference.elgg.org/1.8/annotations_8php_source.html#l00132 :

FROM :

00167         if (elgg_trigger_event('update', 'annotation', $obj)) {
00168             return true;
00169         } else {
00170             // @todo add plugin hook that sends old and new annotation information before db access
00171             elgg_delete_annotation_by_id($annotation_id);
00172         }

TO :

00167         if (elgg_trigger_event('update', 'annotation', $obj)) {
00168             return true;
00169         } else {
00170             // @todo add plugin hook that sends old and new annotation information before db access
00171             return false;
00172         }

[Cash Costello]

Fixes #683 not deleting annotation when event handlers return false on an update

Changeset: 9e311e7236188e826277aed3dca733e02eb21f6a

[Cash Costello]

Fixes #683 not deleting annotation when event handlers return false on an update

Changeset: 9e311e7236188e826277aed3dca733e02eb21f6a