Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit function for comments (Trac #765) #765

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 11 comments
Closed

Edit function for comments (Trac #765) #765

elgg-gitbot opened this issue Feb 16, 2013 · 11 comments

Comments

@elgg-gitbot
Copy link

Original ticket http://trac.elgg.org/ticket/765 on 39115170-05-31 by newlocalmedia, assigned to unknown.

Elgg version: 1.2

Currently it's only possible to delete, not edit, comments.

@elgg-gitbot
Copy link
Author

newlocalmedia wrote on 39115174-10-26

(I meant to classify this as an enhancement as it's not a defect/bug.)

@elgg-gitbot
Copy link
Author

trac user marcus wrote on 39344275-08-15

This appears to have been fixed.

@jdalsem
Copy link
Member

jdalsem commented Jun 20, 2013

as far as i can see you still can't edit generic comments. Editing comments is made possible for forum_topics, but not for generic_comments. I think this should make it into Elgg 1.9 ( @cash @brettp ) as this is very basic functionality. So this ticket needs to be reopend.

@mrclay
Copy link
Member

mrclay commented Jun 20, 2013

I believe @beck24 has a fine plugin for editing comments (would have to be updated for entities though).

@jdalsem
Copy link
Member

jdalsem commented Jun 20, 2013

@mrclay i think it should be part of default Elgg .... how about you?

@juho-jaakkola
Copy link
Member

I wouldn't give this possibility to end users. I think that comments are something that shouldn't be edited afterwards.

Admins however could be an exception. This would make it easier to remove inappropriate content. Then again this might be better as a separate plugin that would for example automatically attach some kind of a note to the comment: "This comment has been edited/hidden by admin because < insert reason >".

@jdalsem
Copy link
Member

jdalsem commented Jun 20, 2013

it is debatable if normal users should be able to edit comments, but
(group) admins should at least have this feature for moderation. If they
only have delete options, this will also cause problems with threaded
comments as they will delete the thread..

Met vriendelijke groet,

Jeroen Dalsem

ColdTrick IT Solutions
Rigtersbleek Zandvoort 10-1.42
7521 BE Enschede
Tel. 053-7114017
Mob. 06-46068234

2013/6/20 Juho Jaakkola notifications@github.com

I wouldn't give this possibility to end users. I think that comments are
something that shouldn't be edited afterwards.

Admins however could be an exception. This would make it easier to remove
inappropriate content. Then again this might be better as a separate plugin
that would for example automatically attach some kind of a note to the
comment: "This comment has been edited/hidden by admin because < insert
reason >".


Reply to this email directly or view it on GitHubhttps://github.com//issues/765#issuecomment-19746669
.

@mrclay
Copy link
Member

mrclay commented Jun 20, 2013

@propertunist
Copy link

i used the edit comment feature on fakebooc many, many times to correct spellings and phrasings..
adding a label to say 'edited' improves the experience..
admin options to decide who can edit comments (and for many other options in elgg) would be a useful addition.

@bjerke
Copy link

bjerke commented Sep 8, 2014

As the users may delete their comments, and add a new edited comment, this is, except for the sequence of the comments, the same as being able to edit - just in a more akward way. Hence, there is no logical reason for making it impossible to edit the users own comments, etc. Actually, I find it a weakness of Elgg.
Editing is also important for another reason: If you work with a comment for some time, it is very good to be able to store the text for the case that something evil should happen, e.g. browser break down or loss of internet connection, or ....

YES, IT LOOKS LIKE YOU ARE RIGHT ...

@ewinslow
Copy link
Contributor

ewinslow commented Sep 8, 2014

I believe this is possible in 1.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

7 participants