SEND mssg loses text if empty() error(s)

[Dhrup]

send.php validates --

Make sure the message field, send to field and title are not blank

if (empty($message_contents)

empty($send_to)

empty($title)) {

...
forward("mod/messages/send.php");

message.php <form;'s input fields are all

input type='text'... value=

so on any *one of the 3 empty errors, when returning to the message form - we lose any text data already input. i guess send.php - instead of the input value= => can check if !empty() and use that value if set.

[cash]

If I understand what he's getting at, the patch attached to this ticket should fix it: ​https://trac.elgg.org/elgg/ticket/1070

[Dhrup]

Replying to cash:

If I understand what he's getting at, the patch attached to this ticket should fix it: ​https://trac.elgg.org/elgg/ticket/1070

Thanks Cash:
I forgot all about this ticket ;-)
1070 is the same problem -- good that it's been fixed.

[cash]

This should be fixed now in svn.