Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify image dimensions in <img> tags (Trac #1279) #1279

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 13 comments
Closed

Specify image dimensions in <img> tags (Trac #1279) #1279

elgg-gitbot opened this issue Feb 16, 2013 · 13 comments
Labels
engine feature
Milestone
Elgg 1.8.x

Comments

@elgg-gitbot
Copy link

Original ticket http://trac.elgg.org/ticket/1279 on 39728347-05-07 by trac user alfalive, assigned to unknown.

Elgg version: 1.6

Google Page Speed addon for Firebug

Says me for example on this page /pg/groups/world/

Specify image dimensions
A width and height should be specified for all images in order to speed up page display. Specifying image dimensions prevents the browser from having to re-position the contents of the page.

Related topic here:
http://community.elgg.org/mod/groups/topicposts.php?topic=284059&group_guid=212067/
@elgg-gitbot
Copy link
Author

Milestone changed to Elgg 1.8 by brettp on 40088236-02-28

@elgg-gitbot
Copy link
Author

Title changed from Specify image dimensions to Specify image dimensions in <img> tags by brettp on 40766424-05-05

@elgg-gitbot
Copy link
Author

Milestone changed to Elgg 1.8.1 by cash on 40888593-02-21

@elgg-gitbot
Copy link
Author

trac user charithccmc wrote on 41249602-02-02

how do we find tag ?

@elgg-gitbot
Copy link
Author

trac user charithccmc wrote on 41249602-05-06

how do we find tags ?

@elgg-gitbot
Copy link
Author

trac user charithccmc wrote on 41249607-03-12

how do we find tags ?

@elgg-gitbot
Copy link
Author

Attachment added by trac user charithccmc on 41254309-10-09: elgg_topbar.patch

@elgg-gitbot
Copy link
Author

ewinslow wrote on 41254788-02-10

Hi, Charith,

Thanks for patch. However, we prefer that you submit a pull request on github against the latest trunk code (1.8). This patch looks like it's against 1.7.

@elgg-gitbot
Copy link
Author

Attachment added by trac user charithccmc on 41261331-01-16: header.patch

@elgg-gitbot
Copy link
Author

cash wrote on 41261429-04-12

Thanks, charithccmc. That looks correct. The elgg_topbar patch looks like it was on 1.7 though.

By the way, do you have a github account?

@elgg-gitbot
Copy link
Author

trac user charithccmc wrote on 41266142-01-10

yes cash. I was submit the patch to github.
https://github.com/charithccmc/Elgg/blob/master/views/installation/page/elements/header.php

@elgg-gitbot
Copy link
Author

trac user Evan Winslow wrote on 42235002-07-21

Refs #1279: Specifying image dimensions in icon/default view.
Changeset: 5c99194

@elgg-gitbot
Copy link
Author

trac user Evan Winslow wrote on 42422630-05-26

Refs #1279: Specifying image dimensions in icon/default view.
Changeset: 5c99194

@elgg-gitbot elgg-gitbot mentioned this issue Feb 16, 2013
Closed
adayth pushed a commit to adayth/Elgg that referenced this issue Feb 22, 2013
@ewinslow
Refs Elgg#1279: Specifying image dimensions in icon/default view.
5c99194
@cash cash closed this as completed Mar 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
engine feature
Milestone
Elgg 1.8.x
Development

No branches or pull requests
2 participants
@cash @elgg-gitbot