We have moved to Github. Please open tickets there.

Opened 3 years ago

Closed 3 years ago

#1450 closed Defect (fixed)

Logout is broken

Reported by: gv Owned by:
Priority: critical Milestone: Elgg 1.7
Component: Core Version: Github Master
Severity: critical Keywords:
Cc: brettp Difficulty:

Description

After updating from Rev 3819 to Rev 3822 the logout does not work anymore. Error message: Form is missing token or ts fields
No possibility to logout!

Attachments (1)

tooladmin.jpeg (255.0 KB) - added by gv 3 years ago.

Download all attachments as: .zip

Change History (23)

comment:1 Changed 3 years ago by brettp

Are you using pure core or 3rd party themes / plugins?

comment:2 Changed 3 years ago by gv

I use some 3rd party plugins with elgg standard theme (see screenshot). I can`t disable any plugins. Error message: Form is missing token or ts fields

Changed 3 years ago by gv

comment:3 follow-ups: Changed 3 years ago by brettp

Please try on most recent SVN.

comment:4 in reply to: ↑ 3 Changed 3 years ago by gv

Replying to brettp:

Please try on most recent SVN.

I beg your pardon??
I have updated to latest Rev (core & plugins) and it messed up the whole site. No logout or plugin disabling possibility. Search field in topbar is broken, owner blocks are broken, customer_index is totally broken all 3rd party plugins are broken and so on. To many irreparable errors for my liking. I'm sure the user will love the update to 1.7! ;-) I think it's a recipe for disaster. cheers

comment:5 Changed 3 years ago by brettp

  • Resolution set to worksforme
  • Status changed from new to closed

comment:6 follow-up: Changed 3 years ago by dave

@gv you need to understand that SVN is code that is being worked on daily, it is not a stable release. It is not for use on production sites and you should expect that there will be issues as features, improvements and bugs are worked through. Once those issues are resolved, that is when an official release goes out for general consumption.

The reason Brett asked you to try the most recent SVN is because he is working on the core and in all likelihood will have sorted a number of the issues reported.

From your comments, may I suggest you might be better off sticking to the official releases?

comment:7 follow-up: Changed 3 years ago by thomas

  • Resolution worksforme deleted
  • Status changed from closed to reopened

In current SVN there is no error on logout anymore, but I'm still unable to log out from elgg. I will be forwarded to the dashboard. Perhaps you could check this issue.

comment:8 in reply to: ↑ 6 Changed 3 years ago by gv

Replying to dave:

@gv you need to understand that SVN is code that is being worked on daily, it is not a stable release. It is not for use on production sites and you should expect that there will be issues as features, improvements and bugs are worked through. Once those issues are resolved, that is when an official release goes out for general consumption.

The reason Brett asked you to try the most recent SVN is because he is working on the core and in all likelihood will have sorted a number of the issues reported.

From your comments, may I suggest you might be better off sticking to the official releases?

@Dave I know what SVN means!!! I just playing and testing arround with SVN. I have no production site, I just wanted to help you with reporting a issue!!! After your reaction I think negative things are not desired or you did not understand me right!? I do not know??

comment:9 in reply to: ↑ 7 Changed 3 years ago by gv

Replying to thomas:

In current SVN there is no error on logout anymore, but I'm still unable to log out from elgg. I will be forwarded to the dashboard. Perhaps you could check this issue.

@thomas I still have the problem on current Rev/SVN?!? What am I doing wrong? I think a 3rd party plugin detaches the problem but I can`t disable any plugin over the pluginmanager.

comment:10 Changed 3 years ago by gv

  • Resolution set to worksforme
  • Status changed from reopened to closed

comment:11 Changed 3 years ago by gv

  • Resolution worksforme deleted
  • Status changed from closed to reopened

comment:12 in reply to: ↑ 3 Changed 3 years ago by thomas

Replying to brettp:

Please try on most recent SVN.

I disabled all non-core plugins by deleting them from the /mod folder, but I'm still unable to log out from elgg.

comment:13 Changed 3 years ago by brettp

@thomas - Can you run upgrade.php and try again? If there is still a problem, please email me a diagnostic report.

comment:14 Changed 3 years ago by thomas

The problem still exists in a complete fresh installation.

comment:15 Changed 3 years ago by TD

CONFIRMED, the problem is extended to most actions that require tokens on my site. Including logging in, logging out, disabling and enabling plugins.

Site Status:

On my system, I am running the latest stable versions of php, apache, and mysql on Mac OS X.
Most recent SVN (as of 10 mins ago). NO additional plugins or modifications to code.
The install root of elgg is at www.website.com/HERE
not www.website.com/

As a quick workaround to fix this problem, you can edit
/engine/lib/actions.php

comment out line 176 so it reads
register_error(elgg_echo('actiongatekeeper:missingfields'));

then create another line below that line and enter the following code:

return TRUE;

this will disable the missing tokens. and is only intended to be a temporary fix.

comment:16 Changed 3 years ago by TD

Also, intermittently when re-visiting the site, I have to delete the browser cookies. Otherwise the page will not load.

comment:17 Changed 3 years ago by brettp

@TD This is an extremely bad idea. Please add a hack to disable tokens as that completely defeats the purpose of testing the latest SVN. I am working on a solution for this, but have thus far been unable to reproduce it so there's some guesswork involved. Again, please DO NOT disable security tokens if you are testing SVN.

comment:18 Changed 3 years ago by brettp

Sorry: "Please *DON'T* add a hack to disable tokens as that completely defeats the purpose of testing the latest SVN."

comment:19 Changed 3 years ago by brettp

(In [svn:3838]) Refs #1450, Refs #1461, Refs #1460: Install now clears out views caches.

comment:20 Changed 3 years ago by TD

Sorry, I was just trying to help him get his site back up. (not as a permanent fix).

I have discovered the problem is related to how the browser stores cookies.
If you delete your cookies you can perform an action. But you have to delete your browser cookies again otherwise you get the "Form is missing token or ts fields" error. So another temporary fix would be to delete your browser cookies before performing every action. Hope it helps you solve this one. Thanks, and keep up the good work (:

comment:21 Changed 3 years ago by brettp

@TD What browser are you using and can you email me a copy of your diagnostics report?

comment:22 Changed 3 years ago by brettp

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [svn:3840]) Fixes #1450, Fixes #1461: Using $_SERVERREQUEST_URI? to pull in GET params on apache servers.

Note: See TracTickets for help on using tickets.