Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide standard method for building hover menu for arbitrary entity types (Trac #2094) #2094

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 12 comments

Comments

@elgg-gitbot
Copy link

Original ticket http://trac.elgg.org/ticket/2094 on 40304671-01-13 by ewinslow, assigned to unknown.

Elgg version: 1.7

Right now users have this nice little menu that drops down when you hover their icon (provided by the profile plugin). A few of us from the community would like to see the same kind of functionality for other entities/annotations as well, but there is no standard way of providing this functionality.

@elgg-gitbot
Copy link
Author

trac user caedes wrote on 40305309-05-04

one way is to provide one (or more) views where plugins can hook to add object related tools. i have made something like this by adding a view called "tools/object" next to all titles for all object types (10 or 15 places), which receives the destination entity for the tools.

this can also be viewed in a way similar to the page_owner, but anyways there must be a hook in some places to put such items, and i imagine people might want to place such tools in different places (next to item titles, on item profiles...).

@elgg-gitbot
Copy link
Author

trac user caedes wrote on 40305310-10-19

also see for more details of the specific case: http://community.elgg.org/mod/groups/topicposts.php?topic=484780&group_guid=7

@elgg-gitbot
Copy link
Author

brettp wrote on 40769559-06-09

Rels #2320

@elgg-gitbot
Copy link
Author

Title changed from Provide standard method for building menu for arbitrary entity types to Provide standard method for building hover menu for arbitrary entity types by brettp on 40769559-06-09

@elgg-gitbot
Copy link
Author

cash wrote on 40996293-12-23

We're most of the way there for this ticket. There is now a single menu system that handles everything from page menus to hover menus. I built a user hover menu with it. The hover menu HTML/JavaScript still needs some clean up. Once that is done, it should be easy to add hover menus to other entities.

Take a look at elgg_view_menu(), elgg_register_menu_item(), the two ElggMenu* classes, and the views in navigation/menu.

I'm moving this back to 1.8.1 since we have so much else to do on 1.8.0.

@elgg-gitbot
Copy link
Author

Milestone changed to Elgg 1.8.1 by cash on 40996293-12-23

@elgg-gitbot
Copy link
Author

ewinslow wrote on 41163795-07-30

Since this is simply asking for hover menu support for arbitrary entities, couldn't we simply convert user_hover => hover and tell plugin authors to check for the type/subtype first before adding menu items?

@elgg-gitbot
Copy link
Author

cash wrote on 41163982-06-13

easy to do on the registration side. The user hover menu view has some code specific to users. We end up with a generic hover menu and a specific user hover menu.

@elgg-gitbot
Copy link
Author

ewinslow wrote on 41164251-12-05

Forgive me -- I'm not quite sure I understood the specifics of your suggestion. Could you rephrase?

@elgg-gitbot
Copy link
Author

cash wrote on 41165100-12-07

The user hover menu is a special exception in that it is structured in three sections and has some special markup. As such, it would be easier to create a generic hover menu view that is distinct from the user hover view.

@elgg-gitbot
Copy link
Author

Milestone changed to Near Term Future Release by cash on 42099861-01-05

@ewinslow
Copy link
Contributor

ewinslow commented Aug 8, 2014

Seems like this can be implemented in a plugin with the existing menus API if you really need it. Doesn't have to be in core.

In addition, hover is a passé concept at this point with the advent of our mobile-sensitive development philosophy.

@ewinslow ewinslow closed this as completed Aug 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants