We have moved to Github. Please open tickets there.

Opened 3 years ago

Closed 2 years ago

#2225 closed Enhancement (fixed)

Update manifest.xml logic to parse semantic XML

Reported by: brettp Owned by:
Priority: low Milestone: Elgg 1.8.0
Component: Core Version: Github Master
Severity: minor Keywords:
Cc: brettp Difficulty: easy

Description

Currently manifest.xml is in the format: 

<field key="name1" value="value1" />
<field key="name2" value="value2" />

I propose using semantic XML instead:

<name1>value1</name1>
<name2>value2</name2>

If this goes in 1.8, we will need to provide backward compatibility with the original format.

Change History (5)

comment:1 Changed 3 years ago by brettp

  • Version changed from 1.7 to SVN Trunk

comment:2 Changed 3 years ago by brettp

  • Difficulty set to easy

While we're making manifest changes like #2170 and #1986 we should add this.

comment:3 Changed 2 years ago by brettp

(In [svn:7481]) Refs #1986 #2170 #2225 Added ElggPluginManifest, ElggPluginManifestParser, and its parser classes for 1.7 and 1.8 style manifests. Changed load_plugin_manifest() to use new parser. Added initial unit tests.

comment:4 Changed 2 years ago by brettp

(In [svn:7512]) Refs #1986 #2170 #2225. Added semantic manifest.xml support and unit tests. Also added plugin dependencies system. See engine/tests/test_files/plugin_18/manifest.xml for examples. Not closing tickets pending discussion.

comment:5 Changed 2 years ago by brettp

  • Resolution set to fixed
  • Status changed from new to closed

(In [svn:7817]) Fixes #1986, #2170, #2225, #2759. Integrated ElggPluginPackage and ElggPluginManifest with ElggPlugin. System now uses ElggPlugin objects to determin plugins. Order is stored in private settings. This absolutely requires running upgrade.php.

Note: See TracTickets for help on using tickets.