Milestone changed to Elgg 1.8.1 by cash on 40894706-07-16

Milestone changed to Elgg 1.8 by cash on 41235107-03-10

cash wrote on 41235121-10-30

(In [svn:8869]) Fixes #2591 removing newlines in queries - thanks to Tachyon

trac user hellekin wrote on 41273249-01-18

Wow, wait a minute!

• You're adding a preg_replace to a function that's used often, just to have pretty logs? That's just plain wrong.
• Replacing CRLF by nothing will break the SQL and allow joining words: isn't that a space you want there?

This "fix" should belong to a log filter, post execution of the SQL: you don't want free bloat, and MySQL will interpret the nicely written query.

brettp wrote on 41275097-09-16

This "fix" should belong to a log filter, post execution of the SQL: you don't want free bloat, and MySQL will interpret the nicely written query.

The removal is for both MySQL logs (which still show the \n) AND the debug log, so it needs to be done pre-execution.

cash wrote on 41275111-05-04

Regarding execution speed, I did some profiling before accepting the patch and this does not add additional time to page creation (that can be measured). If we were doing a 1000 queries per page, it would add a few milliseconds.

Replacing with a space is a valid point. It shouldn't be an issue because we always indent the lines of the query, but it wouldn't hurt.

cash wrote on 41367955-04-14

(In [svn:9067]) Refs #2591 we were not logging inserts, updates, and deletes. Also logging was happening before formatting of the queries. All fixed in this commit.

cash wrote on 41367964-08-18

Fixed the spaces issue also with [svn:9067].

Whether we do this only when logging or for all queries, we're talking about microseconds. I'm fine with only doing it for Elgg logging only since the only time I look at MySQL logs is for slow queries and it is easy to post process those logs. Don't know about other devs.

I'm going to close this for now. We can also reopen if disagreement or something really odds happens and it does affect performance.

cash wrote on 41862123-09-13

Fixes #4071 hellekin was right - it was a bad idea to format queries

Changeset: [8cca602e2bc1c65b99a2d0c2a60255ab09ca4f3d]