Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugins can be listed more than once in enabled_plugins metadata (Trac #2622) #2622

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 7 comments
Closed

plugins can be listed more than once in enabled_plugins metadata (Trac #2622) #2622

elgg-gitbot opened this issue Feb 16, 2013 · 7 comments
Labels
engine
Milestone
Elgg 1.8.0

Comments

@elgg-gitbot
Copy link

Original ticket http://trac.elgg.org/ticket/2622 on 40846788-03-09 by ewinslow, assigned to unknown.

Elgg version: 1.7

Is there any reason that we'd want to allow metadata to contain duplicate values in the same field? i.e.

$site->enabled_plugins; //'plugin', 'plugin', ...

The reason I ask is that our production site got corrupted today during an upgrade and ended up adding multiple duplicates to the 'enabled_plugins' metadata for the site (up to 65k rows). This was causing the site to quickly run out of allotted memory. I'd appreciate a safeguard on the database level to ensure that I can't shoot myself in the foot like that again.
@elgg-gitbot
Copy link
Author

brettp wrote on 40847739-05-22

Saving multiple metadata values for a single metadata name is used throughout Elgg for tagging, plugins, and probably other systems. Putting a restriction on this to disallow multiple identical values would be a special case that can cause headaches later down the road. Instead of changing the data model, we should try to find the bug that caused 65k rows to be duplicated.

@elgg-gitbot
Copy link
Author

Title changed from Add constraint to metadata table: entity_guid, name_id, value_id to plugins can be listed more than once in enabled_plugins metadata by ewinslow on 40920439-09-22

@elgg-gitbot
Copy link
Author

trac user javigs wrote on 40921189-02-05

Same problem, with 1.7.4:
110 rows 'cloned' with a ¿random? unique owner_guid field, not admin enabled. I'll try to re-create this issue.

@elgg-gitbot
Copy link
Author

ewinslow wrote on 40921739-03-20

More details on my blog: http://evanwinslow.com/2010/11/elgg-troubleshooting-allowed-memory-size-of-67108864-bytes-exhausted/

@elgg-gitbot
Copy link
Author

trac user tomv wrote on 40921799-04-07

Maybe nothing to do with it.. but ticket 2177 also shows plugin system can go weird in some cases. Like unsynchronised removing from mod folder without upgrading etc.

@elgg-gitbot
Copy link
Author

brettp wrote on 41016454-12-14

The plugin problem is fixed with #2759, but the metadata duplication problems can still occur on crowded servers. I've opened #2776 for the metadata problem.

@elgg-gitbot
Copy link
Author

Milestone changed to Elgg 1.8 by brettp on 41016454-12-14

@elgg-gitbot elgg-gitbot mentioned this issue Feb 16, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
engine
Milestone
Elgg 1.8.0
Development

No branches or pull requests
1 participant
@elgg-gitbot