Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better multi-site support through customizable settings.php files (Trac #2647) #2647

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 8 comments

Comments

@elgg-gitbot
Copy link

Original ticket http://trac.elgg.org/ticket/2647 on 40864999-08-11 by trac user hellekin, assigned to unknown.

Elgg version: 1.8 Beta

In order to serve multiple Elgg sites from the same directory, the Lorea framework introduced an ELGG_SETTINGS environment variable to set a settings.php file per VirtualHost.

This patch introduces a new file (engine/check.php) that provides a way to determine the path to settings.php prior to loading the engine.

Two implementations are available on Lorea's [https://github.com/lorea/Elgg/commit/e7ca5d0496908f39c5c65023db263b6fc7f275a8 multisites-constant] and [https://github.com/lorea/Elgg/commit/3675da3d966a0a9eac7ac490862652f544ab70e2 multisites-static] branches on Github (links to relevant commits.)

Lorea's [https://github.com/lorea/Elgg/tree/development 1.8 development branch] currently uses the static version of this patch.

@elgg-gitbot
Copy link
Author

Milestone changed to Elgg 1.9 by cash on 40979541-02-14

@elgg-gitbot
Copy link
Author

Title changed from Customizable settings.php file to Better multi-site support through customizable settings.php files by cash on 40979541-02-14

@elgg-gitbot
Copy link
Author

cash wrote on 41490983-09-14

Before starting 1.9, we will review all future release tickets and do assignments.

@elgg-gitbot
Copy link
Author

Milestone changed to Future Release by cash on 41490983-09-14

@ewinslow ewinslow modified the milestones: Elgg 2.0.0, Long Term Future Release Jul 6, 2014
@ewinslow ewinslow added the major label Jul 6, 2014
@ewinslow ewinslow removed this from the Elgg 2.0.0 milestone Jul 10, 2014
@ewinslow
Copy link
Contributor

ewinslow commented Dec 9, 2014

@jdalsem thoughts on this?

@jdalsem
Copy link
Member

jdalsem commented Dec 10, 2014

yeah, this is not the way i envision multisite... as it implies different databases but the same codebase. In my opinion it should be same codebase and same db, but switching sites based on url.

However different settings could also be an option, but then you could already make something like a switch on the site url to include different settings or different settings files based on the url...

for example the settings.php for get the url and then include /settings/<url>.settings for the site specific settings.

It is a bit crude, but it does the trick (easier as suggested). I do not think elgg core could be anymore helpful.

It seems a bit strange to do this as suggested (with a special env var that points to the correct settings). The settings file could have that intelligence in itself.

@jdalsem jdalsem closed this as completed Dec 10, 2014
@beck24
Copy link
Member

beck24 commented Dec 10, 2014

I still haven't done any work with a multisite setup, but I would want to make sure the option is available to use the same codebase but have different databases.

@jdalsem
Copy link
Member

jdalsem commented Dec 11, 2014

yep but that can be done already. I do not see how Elgg could make it much easier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants