Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip registration functions that don't apply (Trac #3003) #3003

Closed
elgg-gitbot opened this issue Feb 16, 2013 · 3 comments
Closed

Skip registration functions that don't apply (Trac #3003) #3003

elgg-gitbot opened this issue Feb 16, 2013 · 3 comments
Labels
engine feature major

Comments

@elgg-gitbot
Copy link

Original ticket http://trac.elgg.org/ticket/3003 on 41155087-01-02 by ewinslow, assigned to unknown.

Elgg version: 1.7

For example, there's a big admin init function that gets run on every page load even if the logged in user is not an admin. We can just skip all that if the user isn't an admin. Similarly, most actions are only valid if a user is logged in. Why bother even registering them all if the user is not logged in?
@elgg-gitbot
Copy link
Author

cash wrote on 41206398-11-25

I think most of those are really cheap. We should find the expensive ones and put checks in for those. For example, I think we do percentage of strings translated when non-admins are logged in.

We also need to make sure we don't break things. If someone implements a roles plugin that allows non-admins to see an admin page, we don't want all the pages to be missing menu items and actions.

@elgg-gitbot
Copy link
Author

Milestone changed to Future Release by cash on 41206398-11-25

@ewinslow ewinslow modified the milestones: Elgg 2.0.0, Long Term Future Release Jul 6, 2014
@ewinslow ewinslow added the major label Jul 6, 2014
@ewinslow ewinslow removed this from the Elgg 2.0.0 milestone Jul 10, 2014
@ewinslow
Copy link
Contributor

This is not where the perf bottleneck is I suspect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
engine feature major
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ewinslow @elgg-gitbot