trac user soniea wrote on 41242361-04-23

Notifications will be sent with this patch.
Plugin setting option yet to be added.

trac user hellekin wrote on 41273299-10-25

I see 3 issues with this patch:

• no gatekeeper
• forward() could be used only once
• tabs (according to Elgg Coding Standard, one should use 4-space-equivalent tab characters)

any update?

ewinslow wrote on 41273966-01-15

Gatekeepers are not needed in actions. The action handler adds them automatically.

Attachment added by trac user soniea on 41293866-11-08: add.php

Attachment added by trac user soniea on 41293869-05-10: edit.php

trac user soniea wrote on 41293873-08-08

Plugin setting to enable or disable email/message notification has been added.
It needs to be put in mod/reportedcontent/views/default/settings/reportedcontent

Regression test on reportedcontent passed.

brettp wrote on 41293934-01-02

Soniea - Trac tickets are only resolved as "Fixed" when we commit the code. Can you please provide a patch against the latest trunk or send a pull request on github?

cash wrote on 41296526-01-29

Sunithi - thanks for the files. A few comments:

• There are some coding standards issues with spaces vs tabs and spacing of statements. See the coding standard in the root directory
• You should not need the echo ' ' in the edit settings view
• There is a new function in Elgg 1.8 for grabbing admin users so that you don't need to write SQL (something like elgg_get_admins())
• You need to pull some of the strings from the notifications out and run them through elgg_echo().

trac user soniea wrote on 41297060-01-13

I've reused edit.php from logrotate with slight modifications.So i'm guessing we need to take care of the echo messages there as well.
Will implement the elgg_get_admins().
I didn't know we had that :D

Please find the interim fix at github.com/soniea/Elgg