We have moved to Github. Please open tickets there.

Opened 16 months ago

Closed 16 months ago

Last modified 16 months ago

#4317 closed Enhancement (fixed)

clean up the boot process

Reported by: cash Owned by: cash
Priority: normal Milestone: Elgg 1.8.4
Component: Core Version: 1.8
Severity: minor Keywords:
Cc: brett@… Difficulty:

Description

Here are the issues:

  1. library loading has two for loops when only one is needed
  1. library loading should be order independent (rather than requiring actions.php and database.php to be loaded first)
  1. there is a mix of functions being called directly from start.php and functions registered for the 'boot', 'system' event
  1. there is code in start.php that can be moved into functions
  1. there is confusion between loading configuration for Elgg as an application (think datalists stuff) and as a site (think config table or ElggSite entity).

I was trying to working on caching and the way the code was distributed made it difficult to understand/change.

My attempt at cleaning this up: https://github.com/cash/Elgg/tree/boot

Change History (4)

comment:1 Changed 16 months ago by cash

  • Milestone changed from Needs Review to Elgg 1.8.4

comment:2 Changed 16 months ago by cash

  • Owner set to cash
  • Status changed from new to assigned

comment:3 Changed 16 months ago by Cash Costello

  • Resolution set to fixed
  • Status changed from assigned to closed

Merge pull request #150 from cash/boot

Fixes #4317 cleans up the boot process

Changeset: 54bef9fc0b85acaf6950e618bd02aa50befd2acc

comment:4 Changed 16 months ago by Cash Costello

Merge pull request #150 from cash/boot

Fixes #4317 cleans up the boot process

Changeset: 54bef9fc0b85acaf6950e618bd02aa50befd2acc

Note: See TracTickets for help on using tickets.