ewinslow wrote on 42340167-09-29

+1000

ewinslow wrote on 42340220-04-03

This should be relatively easy. Would be a good idea to measure the performance gain on various pages too.

Milestone changed to Near Term Future Release by ewinslow on 42340220-04-03

trac user mrclay wrote on 42340233-08-28

One consideration I didn't make explicit: accessibility w/o JS. I've not reviewed the current menu without JS, but CSS hover would not help if the markup wasn't there. The menu on the user profile page would have to substitute for this. is this a concern?

ewinslow wrote on 42340653-01-21

a11y and working without JavaScript are separate issues.

In this case I'm not concerned about the JavaScript part because you can just click through to the user's profile and do what you need to there.

trac user sembrestels wrote on 42544034-11-24

I like the idea too.

Just sticking this on the agenda for 1.9 with low priority. /cc @ewinslow @sembrestels

Whatever we do is going to change in 1.10, right? Are we interested in redoing this so shortly afterwards?

I think this should wait for 1.10

OK cool.

Just mentioning, that commenting out hover menus display on blog listing (10 items) gives me 27% - 39% speed improvement, so it's rather important feature. In general menus system (hover and entity menus) seems to be one of the heavier parts on xdebug.

If that's true it sounds like an amazing performance improvement! Can't wait!

1.8 plugin available for this feature http://community.elgg.org/plugins/1484170/0.1/lazy-hover and on https://github.com/ColdTrick/lazy_hover

Did some cleanup on ColdTrick's plugin: ColdTrick/lazy_hover#3

FYI: when the menus arrive via XHR it might be helpful to fire a JS hook. ColdTrick/lazy_hover#7

Suggest:

• embed data-menu-subject into the UL containing JSON with keys: guid, username, name.
• trigger hook [render, ui.user_hover_menu] after each menu is established in the DOM. For Elgg today, this would mean after DOM ready, core would find all the hover menus and call the hook on each. With lazy hover, this would be fired when a single menu arrives by XHR.
• the hook would be passed a reference to the UL as "menu"

SGTM