We have moved to Github. Please open tickets there.

Opened 12 months ago

Closed 11 months ago

Last modified 11 months ago

#4538 closed Defect (fixed)

Languages not being loaded during plugin activation.

Reported by: brettp Owned by: cash
Priority: high Milestone: Elgg 1.8.6
Component: Core Version: 1.8.5
Severity: minor Keywords:
Cc: brett@… Difficulty: moderate

Description

Causes problems with writing default settings using activate.php. Probably due to changes in ElggPlugin.

Change History (6)

comment:1 Changed 12 months ago by cash

  • Priority changed from normal to high

This causes problems if a plugin registers an admin message when enabled - see categories plugin

comment:2 Changed 12 months ago by cash

Only happens when system cache is turned on. When the plugin calls register_translations(), that function tries to load the translations from the cache and it cannot tell that it does not exist.

register_translations() is too complicated.

comment:3 Changed 11 months ago by cash

I think I have a solution for this now. It requires rewriting the caching code so that all languages are cached the first time after the system cache has been flushed rather than loading them as needed and then caching. This will allow us to not even call register_translations() from the plugin init method when the system cache is turned on (similar to view caching).

comment:4 Changed 11 months ago by cash

  • Owner set to cash
  • Status changed from new to assigned

comment:5 Changed 11 months ago by Cash Costello

  • Resolution set to fixed
  • Status changed from assigned to closed

Merge pull request #274 from cash/language_caching

Fixes #4538 Language caching rewrite

Changeset: 9f5634b5eef06a36f39fa3003ecaa969ef86df75

comment:6 Changed 11 months ago by Cash Costello

Merge pull request #274 from cash/language_caching

Fixes #4538 Language caching rewrite

Changeset: 9f5634b5eef06a36f39fa3003ecaa969ef86df75

Note: See TracTickets for help on using tickets.